Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put structs in the right places #24

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Put structs in the right places #24

merged 2 commits into from
Jul 23, 2021

Conversation

gnidan
Copy link
Owner

@gnidan gnidan commented Jul 23, 2021

As much as possible, use internalType and desired Solidity version to determine where structs should be defined.

  • Track Solidity versions that allow global structs
  • Put structs in the right places:
    • Put local structs in the main output interface
    • Put structs from other contracts in other interfaces
    • Put global structs globally on >=0.6.0
    • Put global structs inside a __Structs wrapper on <0.6.0
  • Prefer unqualified names when referencing a struct
  • Feature structs in the web-ui examples more

g. nicholas d'andrea added 2 commits July 22, 2021 23:30
- Track Solidity versions that allow global structs
- Put structs in the right places:
  - Put local structs in the main output interface
  - Put structs from other contracts in other interfaces
  - Put global structs globally on >=0.6.0
  - Put global structs inside a __Structs wrapper on <0.6.0
- Prefer unqualified names when referencing a struct
@gnidan gnidan merged commit fdd3e63 into master Jul 23, 2021
@gnidan gnidan deleted the struct-containers branch July 23, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant