Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we use python3, it still find python2 #1171

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

HanGuangyu
Copy link

The args[] use "python", and if the version of python is "3",
it will can't find python, because the name is "python3" in o

Add a judge of python version, if the version of python is 3,
set plugin to "python3", if not, plugin still "python".

If the version of Python is 3, api.py can run.

@HanGuangyu
Copy link
Author

Related-Issuse: #1168

Copy link
Contributor

@mrunge mrunge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you. This fixes running unit-tests or running aodh functional tests

@tobias-urdin
Copy link
Contributor

I guess this would only be an issue when not running inside a virtual env that maps python path to python3, but looks good to me.

@tobias-urdin
Copy link
Contributor

@Mergifyio rebase

The args[] use "python", and if the version of python is "3",
it will can't find python, because the name is "python3" in o

Add a judge of python version, if the version of python is 3,
set plugin to "python3", if not, plugin still "python".

If the version of Python is 3, api.py can run.
@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2022

rebase

✅ Branch has been successfully rebased

@mergify mergify bot merged commit 8102662 into gnocchixyz:master Mar 14, 2022
@tobias-urdin
Copy link
Contributor

@Mergifyio backport stable/4.4

@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2022

backport stable/4.4

✅ Backports have been created

mergify bot added a commit that referenced this pull request Mar 14, 2022
When we use python3, it still find python2 (backport #1171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants