Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expo push notifications #86

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Conversation

D4ryl00
Copy link
Contributor

@D4ryl00 D4ryl00 commented Jun 6, 2024

This PR implements the first iteration of Expo push notifications in dSocial.
This enables push notifications for PostReply transactions, so when you reply to a user post.

This PR creates a new notification service that monitors the PostReply transaction on the indexer service, and sends push notifications to users registered on it.
The registration on the notification service is made on the onboarding. But you can also force-register a user in the profile tab.

The discussion that helped me to understand why the notification server got an error on the opened stream with the indexer service: connectrpc/connect-go#757

To build the project, we should have now google-services.jsonandGoogleService-Info.plistin themobilefolder, and donpx expo prebuild --clean` at least one time.

fixes #87

@D4ryl00 D4ryl00 self-assigned this Jun 6, 2024
@costinberty costinberty mentioned this pull request Jun 6, 2024
@D4ryl00 D4ryl00 force-pushed the feat/expo-push-notif branch 3 times, most recently from d6e4944 to 7449966 Compare June 25, 2024 13:50
…ribe to

Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
… on PostReply transactions

Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
…Token and register device to the new push notification service

Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
@D4ryl00 D4ryl00 requested review from iuricmp and jefft0 June 26, 2024 09:12
Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on physical Android and iPhone. Tested replies with "app running", "app closed", "phone off".

@D4ryl00 D4ryl00 merged commit cea2d9d into gnolang:main Jul 1, 2024
@D4ryl00 D4ryl00 deleted the feat/expo-push-notif branch July 1, 2024 09:36
Copy link

github-actions bot commented Jul 1, 2024

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push Notifications
2 participants