-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significantly long GnoVM test runtime #1406
Comments
Maybe we should make the VM thread-safe, to make it possible to run several of them simultaneously. |
This is actually something that is required down the line, we can't do gas estimations (through an RPC call, cc @MichaelFrazzy) and state transitions at the same time with the current VM |
I also lean towards this idea. // NOTE: for allocation, use *Allocator.NewBlock.
func NewBlock(source BlockNode, parent *Block) *Block It takes about 7% of the runtime. |
Is this test similar in function to the benchmarking framework that Dylan set up or something that we've had for a while? |
Description
Running the gnovm test suite takes an extraordinarily long amount of time to execute:
For CI runs, take a look at an example GnoVM CI run:
https://github.com/gnolang/gno/actions/runs/7031801537/job/19134177743
Notice that
pkg0
,pkg1
,pkg2
take ~13mins to execute in the CI.An additional problem is that we cannot execute the VM tests in parallel (
t.Parallel()
), since there are primitives in the VM preventing parallel execution (global vars).This long test suite execution time takes a large toll on local development and CI workflows.
@ajnavarro @gfanton please add more info to this task if I've missed something, @petar-dambovaliev will look into the issue
The text was updated successfully, but these errors were encountered: