Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GnoVM/TM2] Limiting package functionality #2224

Closed
leohhhn opened this issue May 28, 2024 · 2 comments
Closed

[GnoVM/TM2] Limiting package functionality #2224

leohhhn opened this issue May 28, 2024 · 2 comments

Comments

@leohhhn
Copy link
Contributor

leohhhn commented May 28, 2024

Description

As discussed on the Belgrade retreat, we came to conclusions about pure packages:

  • We should forbid direct calls to p/ via maketx call, qeval, or other. In essence, p/ should be only callable by other code (while on this note, we should also forbid the same for stdlibs - reference comment)
  • We should panic if p/ tries to get any type of banker (or possibly allow only ReadOnly banker?)
  • We should panic if the user tries to change state in a p/, instead of just letting the transaction go through without applying the state change - related issue

cc @moul

@moul
Copy link
Member

moul commented May 28, 2024

Can you merge with #2192 ?

@leohhhn
Copy link
Contributor Author

leohhhn commented May 28, 2024

Closing in favor of #2192

@leohhhn leohhhn closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants