Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/append balances and txs when genesis exists #2391

Open
mazzy89 opened this issue Jun 19, 2024 · 3 comments · May be fixed by #2444
Open

Add/append balances and txs when genesis exists #2391

mazzy89 opened this issue Jun 19, 2024 · 3 comments · May be fixed by #2444
Assignees

Comments

@mazzy89
Copy link
Contributor

mazzy89 commented Jun 19, 2024

Description

When gnoland starts with lazy flag, the genesis is crafted adding balances and txs. when gnoland start without the lazy flag, if the genesis already exists then balances and txs are not added to the genesis then flags such as -genesis-balances-file aren't used.

From my standpoint, it would make sense to honor those flags in any case even when the genesis exists and add/append their content into the crafted genesis.

@grepsuzette
Copy link
Contributor

grepsuzette commented Jun 26, 2024

From my standpoint, it would make sense to honor those flags in any case even when the genesis exists and add/append their content into the crafted genesis.

I think it should not be possible to modify balances out of thin air after a chain is created.
You would instead use something like gnofaucet?

@zivkovicmilos
Copy link
Member

@mazzy89 you're if the genesis.json exists already at the path, the lazy init (which utilizes these flags / files) is skipped

We're actually looking to completely drop those files from the gnoland start command, because they have no place there, since gnoland genesis covers all of their functionality

@mazzy89
Copy link
Contributor Author

mazzy89 commented Jun 26, 2024

Thanks @zivkovicmilos

@grepsuzette I was referring to the case when the user could pass in a genesis.json not fully filled of txs and balances (and the network has not started yet so height is 0). My initial assumption was those flags would be honored anyways but seems that indeed as Milos explanation, those are honored only in the presence of lazy init.

Thanks for making it clearer with the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants