feat: make gnovm wasm-friendly #1012

moul · 2023-08-01T10:21:06Z

fix tm2/pkg/autofile
setup CI check
skip fix leveldb
have sane defaults for db on wasm (chore: switch to gnolang/goleveldb and cleanup moul/gno#3)

Fixes #1008
Addresses #1013

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests
Added new benchmarks to generated graphs, if any. More info here.

@ilgooz

h/t @ilgooz (pair-programming session) Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

moul · 2023-08-01T10:44:33Z

tm2/pkg/iavl/nodedb.go

@@ -117,14 +117,6 @@ func (ndb *nodeDB) SaveNode(node *Node) {
 // Has checks if a hash exists in the database.
 func (ndb *nodeDB) Has(hash []byte) bool {
 	key := ndb.nodeKey(hash)
-
-	if ldb, ok := ndb.db.(*dbm.GoLevelDB); ok {


Hey @jaekwon, something seems off here. GoLevelDB.Has() is essentially checking if GoLevelDB.Get() is not nil, making this condition alter the function's behavior to panic instead of returning false, specifically when using a particular driver.

Would you be alright with removing this code, or do you have a different approach in mind?

PR should be ready after resolving this.

tm2/pkg/autofile/autofile_wasm.go

Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

ilgooz · 2023-08-01T13:59:43Z

Here is my counter PR based in this one.

chore: switch to `gnolang/goleveldb` and cleanup

ilgooz · 2023-08-02T07:17:59Z

@moul one more PR: moul#4

chore: fix database adapter and bump gnolang/goleveldb version

ilgooz · 2023-08-02T08:19:26Z

cc @jeronimoalbi for the failing db checks

jeronimoalbi · 2023-08-03T11:40:48Z

cc @jeronimoalbi for the failing db checks

The issue seems to be either a new feature or bug introduced in goleveldb at some point after v1.0.0 release.
They don't have any tags after that one.

The tests break because setting []byte("") as value returns nil when Get() is called.

I think we should apply your goleveldb changes to changeset 9d007e4 which is the one that was tagged as v1.0.0. Maybe the fork should remove the changesets that followed v1.0.0.

ilgooz · 2023-08-04T06:04:15Z

@jeronimoalbi thanks for debugging, I'll make a PR.

ilgooz · 2023-08-04T06:27:37Z

Fixed in this PR: moul#5

moul · 2023-08-10T16:25:34Z

Changes justifying a fork of goleveldb: syndtr/goleveldb@4512381

moul · 2023-08-10T16:29:59Z

Next steps regarding DB: #1013

Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: İlker G. Öztürk <ilker@ilgooz.com>

moul added 2 commits August 1, 2023 12:20

chore: make autofile wasm-friendly

d87146a

h/t @ilgooz (pair-programming session) Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

ci: setup wasm check on gnovm

8860136

moul self-assigned this Aug 1, 2023

moul changed the title ~~dev/moul/wasm~~ feat: wasm support Aug 1, 2023

moul changed the title ~~feat: wasm support~~ feat: wasm-friendly Aug 1, 2023

github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Aug 1, 2023

moul added 2 commits August 1, 2023 12:22

chore: fixup

6ae7488

chore: skip leveldb import for wasm

5b8953d

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

moul commented Aug 1, 2023

View reviewed changes

ilgooz reviewed Aug 1, 2023

View reviewed changes

tm2/pkg/autofile/autofile_wasm.go Show resolved Hide resolved

Update tm2/pkg/autofile/autofile_wasm.go

9f7b4e0

Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>

moul changed the title ~~feat: wasm-friendly~~ feat: make gnovm wasm-friendly Aug 1, 2023

moul added 5 commits August 1, 2023 12:58

chore: use memdb for wasm

fcb6fdd

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

chore: use memdb for wasm

7166b65

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

chore: fix build constraints

a626142

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

chore: improve comments

ffc6cf0

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

chore: fixup

f2d6709

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>

moul assigned ilgooz Aug 1, 2023

moul mentioned this pull request Aug 1, 2023

Refactor DB Backends #1013

Open

ilgooz added 2 commits August 1, 2023 16:49

refactor: change syndtr/goleveldb with gnolang/goleveldb

76a0ec4

revert some changes

f9fe54c

This was referenced Aug 1, 2023

Add support for WASM in goleveldb dependency #1008

Closed

refactor(tm2/pkg/autofile): use SIGTERM #1006

Closed

moul and others added 4 commits August 2, 2023 01:20

Update misc/deployments/staging.gno.land/overlay/config.toml

a535c75

Merge pull request #3 from ilgooz/ilgooz/wasm-additions

0482c08

chore: switch to `gnolang/goleveldb` and cleanup

fix: db backend

f75a4f0

chore: bump gnolang/golevledb version to v0.1.0

c5cc1f4

Merge pull request #4 from ilgooz/fix/wasm-friendly

d63be77

chore: fix database adapter and bump gnolang/goleveldb version

ilgooz added 2 commits August 4, 2023 09:20

chore: bump gnolang/golevledb version to v0.0.9

9b83027

fmt

2e4a88c

Merge pull request #5 from ilgooz/chore/wf-bump

d0c98d1

moul marked this pull request as ready for review August 7, 2023 14:52

moul requested review from jaekwon and a team as code owners August 7, 2023 14:52

Merge branch 'master' into dev/moul/wasm

18609f0

ilgooz approved these changes Aug 7, 2023

View reviewed changes

zivkovicmilos self-requested a review August 7, 2023 15:02

zivkovicmilos approved these changes Aug 10, 2023

View reviewed changes

moul mentioned this pull request Aug 10, 2023

Minutes: GitHub Review Meetings [every Thursday] gnolang/meetings#18

Open

3 tasks

moul merged commit 5a1d497 into gnolang:master Aug 10, 2023
77 checks passed

moul deleted the dev/moul/wasm branch August 10, 2023 16:55

Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023

feat: make gnovm wasm-friendly (gnolang#1012)

4dc3071

Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: İlker G. Öztürk <ilker@ilgooz.com>

moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: make gnovm wasm-friendly #1012

feat: make gnovm wasm-friendly #1012

moul commented Aug 1, 2023 •

edited

moul Aug 1, 2023

ilgooz Aug 4, 2023

ilgooz commented Aug 1, 2023 •

edited

ilgooz commented Aug 2, 2023

ilgooz commented Aug 2, 2023

jeronimoalbi commented Aug 3, 2023

ilgooz commented Aug 4, 2023

ilgooz commented Aug 4, 2023

moul commented Aug 10, 2023

moul commented Aug 10, 2023

feat: make gnovm wasm-friendly #1012

feat: make gnovm wasm-friendly #1012

Conversation

moul commented Aug 1, 2023 • edited

moul Aug 1, 2023

Choose a reason for hiding this comment

ilgooz Aug 4, 2023

Choose a reason for hiding this comment

ilgooz commented Aug 1, 2023 • edited

ilgooz commented Aug 2, 2023

ilgooz commented Aug 2, 2023

jeronimoalbi commented Aug 3, 2023

ilgooz commented Aug 4, 2023

ilgooz commented Aug 4, 2023

moul commented Aug 10, 2023

moul commented Aug 10, 2023

moul commented Aug 1, 2023 •

edited

ilgooz commented Aug 1, 2023 •

edited