docs: fix outdated documentation in r/demo/boards #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
moul
approved these changes
Aug 2, 2023
harry-hov
reviewed
Aug 3, 2023
harry-hov
reviewed
Aug 3, 2023
harry-hov
reviewed
Aug 3, 2023
harry-hov
reviewed
Aug 3, 2023
harry-hov
reviewed
Aug 3, 2023
harry-hov
reviewed
Aug 3, 2023
harry-hov
reviewed
Aug 3, 2023
harry-hov
reviewed
Aug 3, 2023
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
harry-hov
reviewed
Aug 3, 2023
gfanton
force-pushed
the
fix/gno-land-remote
branch
from
096e27f
to
9c8931e
Compare
|
@harry-hov updated ! thanks ! |
|
Wow. That was quick. Thanks, @gfanton! |
harry-hov
approved these changes
Aug 3, 2023
|
I'm just nitpicking. Can you modify the PR title to match the changes - Maybe? fix(doc): update broken paths and link in Or something better. |
|
Even better: Use 'docs' instead of 'fix' in the commit message, and clarify the change made for the end-user, not just the contribution. See https://www.conventionalcommits.org/en/v1.0.0/ and https://github.com/semantic-release/semantic-release for details. |
gfanton
changed the title
gno.land address with test3.gno.land
|
@moul @harry-hov make sense! i've updated the title and the body of the PR as requested! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrects outdated documentation in
examples/gno.land/r/demo/boards/README.md:gno.land:36657was replaced with the working addresstest3.gno.land:36657as the former is no longer functional.gno.land/r/boardswas replaced with the new pathgno.land/r/demo/boardsThis change ensures that users following the instructions in the README will be able to successfully connect to gnoland node using the correct address, avoiding potential issues related to using an outdated address.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description