fix: correct panic message for ParseMemPackage() #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ParseMemPackage() function panics when encountering a package name mismatch. The panic message stated, "expected package name [%s] or [%s_test], but got [%s]". However, since we are skipping the _test.gno files, we should never expect `[%s_test]` as a package name. This commit fixes the error message to accurately reflect this condition. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
3 tasks
moul
approved these changes
Aug 17, 2023
Doozers
pushed a commit
to Doozers/gno
that referenced
this pull request
Aug 31, 2023
The ParseMemPackage() function panics when encountering a package name mismatch. The panic message stated, "expected package name [%s] or [%s_test], but got [%s]". However, since we are skipping the _test.gno files, we should never expect `[%s_test]` as a package name. This commit fixes the error message to accurately reflect this condition. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ParseMemPackage() function panics when encountering a
package name mismatch. The panic message stated,
"expected package name [%s] or [%s_test], but got [%s]". However,
since we are skipping the _test.gno files, we should never expect
[%s_test]as a package name. This commit fixes the error messageto accurately reflect this condition.
Signed-off-by: Hariom Verma hariom.verma@tendermint.com
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description