Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pkg/commands): readPassword support for windows #1089

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix(pkg/commands): readPassword support for windows #1089

merged 1 commit into from
Aug 31, 2023

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Aug 30, 2023

fixes #1060 (maybe). @ekleiner to verify :)

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Aug 30, 2023
@thehowl thehowl mentioned this pull request Aug 30, 2023
Closed
zivkovicmilos
zivkovicmilos approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

moul
moul approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could be nice to add an integration test to avoid breaking this in the future.

@moul moul merged commit 236c112 into master Aug 31, 2023
64 checks passed
@moul moul deleted the dev/morgan/fix-1060 branch August 31, 2023 17:05
@thehowl thehowl mentioned this pull request Aug 31, 2023
Open
3 tasks
@moul moul added this to the 💡Someday/Maybe milestone Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@jaekwon jaekwon Awaiting requested review from jaekwon jaekwon is a code owner

Assignees

@thehowl thehowl

Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
TM2/GnoVM
Status: Done
🚀 The Launch
Archived in project
🧐 Review Meeting
Archived in project
Milestone
💡Someday/Maybe
Development

Successfully merging this pull request may close these issues.

make install build fails on non-wsl Windows 11 environment
3 participants
@thehowl @moul @zivkovicmilos