Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump golang at go1.21 #1093

Merged
merged 4 commits into from
Sep 4, 2023
Merged

chore: bump golang at go1.21 #1093

merged 4 commits into from
Sep 4, 2023

Conversation

moul
Copy link
Member

@moul moul commented Sep 4, 2023 •
edited

  • bump go@v1.21
  • stop testing go1.19
  • bump golangci-lint@v1.54
  • fix lint issues
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@moul
chore: bump golang at go1.21
e5177da 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Sep 4, 2023
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Sep 4, 2023
@moul
chore: fixup
245e0d6 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul
chore: fixup
2961617 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul mentioned this pull request Sep 4, 2023
Closed
7 tasks
@moul moul marked this pull request as ready for review September 4, 2023 00:56
@moul moul requested review from jaekwon and a team as code owners September 4, 2023 00:56
@moul
chore: fixup
6a4dbbe 
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Sep 4, 2023
ajnavarro
ajnavarro reviewed Sep 4, 2023
View reviewed changes
tm2/pkg/store/cache/store.go
Comment on lines +175 to 176
// #nosec G602
for e := store.sortedCache.Front(); e != nil && len(unsorted) != 0; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we refactor this code and fix it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's a false positive, protected by the len(unsorted) != 0 we can see in line 176.

Looking for additional feedback, anyone?

zivkovicmilos
zivkovicmilos approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@moul moul merged commit 3cd11c1 into gnolang:master Sep 4, 2023
76 of 79 checks passed
@moul moul deleted the dev/moul/bump-go-121 branch September 4, 2023 15:09
@moul moul added this to the 💡Someday/Maybe milestone Sep 6, 2023
@moul moul mentioned this pull request Sep 10, 2023
Merged
@moul moul mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@jaekwon jaekwon Awaiting requested review from jaekwon jaekwon is a code owner

Assignees

@moul moul

Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
TM2/GnoVM
Status: Done
😎 Manfred's Board
Status: Done
🚀 The Launch
Archived in project
🧐 Review Meeting
Archived in project
Milestone
💡Someday/Maybe
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moul @ajnavarro @zivkovicmilos