Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add empty test files for consistent coverage #1147

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

moul
Copy link
Member

@moul moul commented Sep 18, 2023

Fixing this: CleanShot 2023-09-18 at 16 29 59

Related with #1139

@moul moul self-assigned this Sep 18, 2023
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Sep 18, 2023
@moul moul changed the title dev/moul/empty tests chore: add empty test files for consistent coverage Sep 18, 2023
@github-actions github-actions bot removed the 🧾 package/realm Tag used for new Realms or Packages. label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1147 (6e96574) into master (b7bf42a) will decrease coverage by 4.79%.
The diff coverage is n/a.

❗ Current head 6e96574 differs from pull request most recent head 9a955e4. Consider uploading reports for the commit 9a955e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
- Coverage   46.97%   42.19%   -4.79%     
==========================================
  Files         364       11     -353     
  Lines       61148     1050   -60098     
==========================================
- Hits        28722      443   -28279     
+ Misses      30061      590   -29471     
+ Partials     2365       17    -2348     
Flag Coverage Δ
gno.land-_test.gnokey 0.00% <ø> (∅)
gno.land-_test.gnoland 88.14% <ø> (ø)
gno.land-_test.pkgs 27.88% <ø> (ø)
gnovm-_test.cmd ?
gnovm-_test.gnolang.native ?
gnovm-_test.gnolang.other ?
gnovm-_test.gnolang.pkg0 ?
gnovm-_test.gnolang.pkg1 ?
gnovm-_test.gnolang.pkg2 ?
gnovm-_test.gnolang.realm ?
gnovm-_test.gnolang.stdlibs ?
gnovm-_test.pkg ?
tm2-_test.pkg.amino ?
tm2-_test.pkg.bft ?
tm2-_test.pkg.others ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
tm2 ∅ <ø> (∅)
gnovm ∅ <ø> (∅)
gno.land 42.19% <ø> (-0.33%) ⬇️

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as ready for review September 18, 2023 14:33
@moul moul requested a review from a team as a code owner September 18, 2023 14:33
@moul
Copy link
Member Author

moul commented Sep 18, 2023

This code coverage decrease is probably correct, because we've new files with untested lines. So, maybe your last edit @ajnavarro #1146 is maybe good!

@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 18, 2023
@moul moul merged commit 61f3ada into gnolang:master Sep 18, 2023
23 checks passed
@moul moul deleted the dev/moul/empty-tests branch September 18, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants