test(gno build): remove exit code assertion #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes gnolang#1258 Can't explain why but Jae has exit code 2 where most people have exit code 1. Decided to remove the code assertion since it doesn't really matter.
thehowl
approved these changes
Oct 19, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1261 +/- ##
==========================================
- Coverage 47.84% 47.81% -0.04%
==========================================
Files 369 369
Lines 62764 62716 -48
==========================================
- Hits 30028 29985 -43
+ Misses 30308 30295 -13
- Partials 2428 2436 +8 ☔ View full report in Codecov by Sentry. |
thehowl
pushed a commit
to thehowl/gno
that referenced
this pull request
Oct 21, 2023
Closes gnolang#1258 Can't explain why but Jae has exit code 2 where most people have exit code 1. Decided to remove the code assertion since it doesn't really matter. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
Closes gnolang#1258 Can't explain why but Jae has exit code 2 where most people have exit code 1. Decided to remove the code assertion since it doesn't really matter. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1258
Can't explain why but Jae has exit code 2 where most people have exit code 1.
Decided to remove the code assertion since it doesn't really matter.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description