feat: Porting io/fs package #1323
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1323 +/- ##
==========================================
- Coverage 55.91% 55.09% -0.82%
==========================================
Files 420 421 +1
Lines 65415 66441 +1026
==========================================
+ Hits 36578 36608 +30
- Misses 25977 26957 +980
- Partials 2860 2876 +16 ☔ View full report in Codecov by Sentry. |
|
|
|
Test Failed on |
✅ Deploy Preview for gno-docs2 canceled.
|
github-actions
bot
added
the
🧾 package/realm
| // func (d dirInfo) String() string { | ||
| // | ||
| // } |
There was a problem hiding this comment.
Keep the comments from the original, as well as the copyright header.
| // if err := fstest.TestFS(myFS, "file/that/should/be/present"); err != nil { | ||
| // t.Fatal(err) | ||
| // } | ||
| // func TestFS(fsys fs.FS, expected ...string) error { |
|
|
||
| // checkDir checks the directory dir, which is expected to exist | ||
| // (it is either the root or was found in a directory listing with IsDir true). | ||
| // func (t *fsTester) checkDir(dir string) { |
There was a problem hiding this comment.
This one needs to have commented functions uncommented, or if they rely on features we don't support then they need an appropriate // XXX comment
as well as testfs_test.go, please :)
|
@thehowl First of all, thanks for the detailed review as always. It's been quite some time since I add this, and there are many parts I simply marked "no" and commented out. So, It's challenging to make immediate corrections. Thus, I plan to revert to a "draft" and make comprehensive changes :) |
Description
Note:
sort.Sliceis not supported yet (this method hasinternal/reflectliteas an dependency). So, I've temporarily filled in the blanks with a basic sorting algorithm - like Quick Sort - which will need to be fixed later.related with: #1267