Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve Docusaurus build #1351

Merged
merged 6 commits into from
Nov 10, 2023

Conversation

zivkovicmilos
Copy link
Member

Description

This PR fixes dangling HTML tags in the Docusaurus config, as well as introduces a workflow file that will make sure the Docusaurus documentation is built correctly

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added the hotfix Major bug fix that should be merged ASAP label Nov 9, 2023
@zivkovicmilos zivkovicmilos self-assigned this Nov 9, 2023
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner November 9, 2023 22:34
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for gno-docs2 canceled.

Name Link
🔨 Latest commit f397169
🔍 Latest deploy log https://app.netlify.com/sites/gno-docs2/deploys/654df3899aa90a000899ca33

@zivkovicmilos zivkovicmilos changed the title hotfix: resolve Docusaurus build fix: resolve Docusaurus build Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc5af65) 55.96% compared to head (f397169) 55.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1351      +/-   ##
==========================================
- Coverage   55.96%   55.95%   -0.02%     
==========================================
  Files         420      420              
  Lines       65415    65415              
==========================================
- Hits        36612    36603       -9     
- Misses      25948    25956       +8     
- Partials     2855     2856       +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just nits

docs/explanation/gnovm.md Outdated Show resolved Hide resolved
.github/workflows/docusaurus.yml Outdated Show resolved Hide resolved
zivkovicmilos and others added 4 commits November 10, 2023 09:45
Co-authored-by: Danny <salman.danny03@hotmail.com>
Co-authored-by: Danny <salman.danny03@hotmail.com>
@zivkovicmilos zivkovicmilos added the 📖 documentation Improvements or additions to documentation label Nov 10, 2023

- name: Install Docusaurus Dependencies
run: |
cd misc/docusaurus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, we can set the working_directory

@moul moul merged commit 98f384e into gnolang:master Nov 10, 2023
183 checks passed
@zivkovicmilos zivkovicmilos deleted the hotfix/docusaurus-build branch November 10, 2023 14:40
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
## Description

This PR fixes dangling HTML tags in the Docusaurus config, as well as
introduces a workflow file that will make sure the Docusaurus
documentation is built correctly

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Danny <salman.danny03@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation hotfix Major bug fix that should be merged ASAP
Projects
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants