Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tidy gnokeykc go mod #1355

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix: tidy gnokeykc go mod #1355

merged 3 commits into from
Nov 13, 2023

Conversation

zivkovicmilos
Copy link
Member

Description

This PR runs go mod tidy on gnokeykc.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added the 🌟 improvement performance improvements, refactors ... label Nov 10, 2023
@zivkovicmilos zivkovicmilos self-assigned this Nov 10, 2023
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner November 10, 2023 13:54
@netlify Netlify
Copy link

netlify bot commented Nov 10, 2023 •
edited

✅ Deploy Preview for gno-docs2 canceled.

Name Link
🔨 Latest commit 14f0870
🔍 Latest deploy log https://app.netlify.com/sites/gno-docs2/deploys/654e41162b3547000827da9d

@thehowl
Copy link
Member

thehowl commented Nov 10, 2023

Looks good, can you make it so that the modtidy CI checks works for all subdirectories with gno.mod? (Think you can adapt Harry's script in examples for this.)

@zivkovicmilos
Copy link
Member Author

zivkovicmilos commented Nov 10, 2023 •
edited

Looks good, can you make it so that the modtidy CI checks works for all subdirectories with gno.mod? (Think you can adapt Harry's script in examples for this.)

I just checked, this line in the CI should already pick up these go.mod files

gomods=$(find . -type f -name go.mod)

I went back and checked, and the CI supposedly passed for this on the PR where the go.mod was introduced:
https://github.com/gnolang/gno/actions/runs/6815439829/job/18534536574

I'll look into fixing the CI in this PR, should be straightforward

@zivkovicmilos
Copy link
Member Author

@thehowl

I've updated the script, I am unsure why the previous one would always return OK 🤷‍♂️ :

695f788

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98f384e) 55.93% compared to head (14f0870) 55.96%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1355      +/-   ##
==========================================
+ Coverage   55.93%   55.96%   +0.02%     
==========================================
  Files         420      420              
  Lines       65415    65415              
==========================================
+ Hits        36592    36608      +16     
+ Misses      25966    25950      -16     
  Partials     2857     2857

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thehowl
thehowl approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run the action locally and it errors correctly. let's go!

@thehowl thehowl merged commit bc2d5cf into gnolang:master Nov 13, 2023
183 checks passed
@zivkovicmilos zivkovicmilos deleted the fix/tidy-kc-mod branch November 13, 2023 18:33
@thehowl thehowl mentioned this pull request Nov 13, 2023
Merged
thehowl added a commit that referenced this pull request Nov 13, 2023
@thehowl
chore(mod): tidy all go mods (#1370)
43b3ac5 
the CI errors out after #1355, oops...
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
@zivkovicmilos @moul
fix: tidy gnokeykc go mod (gnolang#1355)
7b8b922 
## Description

This PR runs `go mod tidy` on `gnokeykc`.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
@thehowl @moul
chore(mod): tidy all go mods (gnolang#1370)
16116fe 
the CI errors out after gnolang#1355, oops...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

@thehowl thehowl thehowl approved these changes

Assignees

@zivkovicmilos zivkovicmilos

Labels
🌟 improvement performance improvements, refactors ...
Projects
🚀 The Launch
Status: No status
🧐 Review Meeting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zivkovicmilos @thehowl @moul