chore: In processSig, clarify the signature verification failed error message #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
- Coverage 55.98% 55.62% -0.37%
==========================================
Files 420 420
Lines 65443 65441 -2
==========================================
- Hits 36640 36400 -240
- Misses 25940 26188 +248
+ Partials 2863 2853 -10 ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Nov 20, 2023
zivkovicmilos
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three ways that a signature verification can fail: bad account number, bad sequence number and wrong chain ID. The current error message says "verify correct account sequence and chain-id". This is confusing. For example, it may seem that "account sequence" is one thing. This PR clarifies the error message by adding commas: "verify correct account, sequence, and chain-id".