Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement gno mod why #1407

Merged
merged 10 commits into from
Feb 28, 2024
Merged

feat: implement gno mod why #1407

merged 10 commits into from
Feb 28, 2024

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Dec 4, 2023 •
edited

gno mod why: explains why packages or modules are needed

Also answers the question "why is this package or module being kept by gno mod tidy?"

Screenshot 2023-12-05 at 4 54 54 PM
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Dec 4, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.47%. Comparing base (1065217) to head (ec4f0af).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   47.47%   47.47%           
=======================================
  Files         385      385           
  Lines       61377    61377           
=======================================
  Hits        29140    29140           
  Misses      29802    29802           
  Partials     2435     2435

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos zivkovicmilos mentioned this pull request Dec 5, 2023
Open
@harry-hov harry-hov marked this pull request as ready for review December 5, 2023 17:51
@harry-hov harry-hov requested a review from a team as a code owner December 5, 2023 17:51
leohhhn
leohhhn requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments regarding the docs 🙏

docs/explanation/gno-modules.md Outdated Show resolved Hide resolved
gnovm/cmd/gno/mod.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/mod.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/mod.go Outdated Show resolved Hide resolved
@michelleellen michelleellen mentioned this pull request Dec 13, 2023
Open
thehowl
thehowl reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments from the other day that I forgot to finalise. Publishing as I saw that you just pushed a commit, so I think you're taking a look at this now.

I haven't 100% finished the review; will do later.

docs/explanation/gno-modules.md Outdated Show resolved Hide resolved
gnovm/cmd/gno/mod.go Show resolved Hide resolved
gnovm/cmd/gno/mod.go Show resolved Hide resolved
gnovm/cmd/gno/mod.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/mod.go Outdated Show resolved Hide resolved
gnovm/cmd/gno/mod.go Outdated Show resolved Hide resolved
@harry-hov harry-hov requested review from jaekwon, moul and a team as code owners February 12, 2024 15:43
thehowl
thehowl reviewed Feb 19, 2024
View reviewed changes
gnovm/cmd/gno/mod.go Outdated Show resolved Hide resolved
@harry-hov
Copy link
Contributor Author

Forced pushed to resolve merge conflicts. Will be merging once CI passes.

@harry-hov harry-hov merged commit b965e5e into gnolang:master Feb 28, 2024
190 of 191 checks passed
@harry-hov harry-hov deleted the hariom/gno-mod-why branch February 28, 2024 20:52
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
@harry-hov @leohhhn
feat: implement gno mod why (gnolang#1407)
640b3ee 
`gno mod why`: explains why packages or modules are needed

Also answers the question "why is this package or module being kept by
`gno mod tidy`?"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl thehowl approved these changes

@leohhhn leohhhn leohhhn approved these changes

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

@jaekwon jaekwon Awaiting requested review from jaekwon

@moul moul Awaiting requested review from moul moul is a code owner

@ajnavarro ajnavarro Awaiting requested review from ajnavarro

@gfanton gfanton Awaiting requested review from gfanton

Assignees

@harry-hov harry-hov

Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
🚀 The Launch
Status: No status
🧐 Review Meeting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harry-hov @thehowl @leohhhn