fix: untyped values use calling builtin function's type #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1423 +/- ##
==========================================
- Coverage 56.31% 55.79% -0.53%
==========================================
Files 422 431 +9
Lines 65699 68649 +2950
==========================================
+ Hits 37000 38303 +1303
- Misses 25817 27381 +1564
- Partials 2882 2965 +83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
piux2
reviewed
Dec 20, 2023
zivkovicmilos
approved these changes
Dec 22, 2023
|
@deelawn awesome, LGTM |
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> Addresses gnolang#1085 The call to `convConst` should include the type in this case. This happens while processing a `CallExpr` and in this case the expression is a function call to the built function `uint64`. We have the expected type, so use when converting the constant to a typed value. If this type is still nil, then it will behave as it does currently. However, the concrete type should only be supplied to `convertConst` if the call expression's type and the constant expression's type both have the same underlying _unsigned type_ -- the base type of any value of these types were they to be evaluated as literals before being assigned a type. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1085
The call to
convConstshould include the type in this case. This happens while processing aCallExprand in this case the expression is a function call to the built functionuint64. We have the expected type, so use when converting the constant to a typed value. If this type is still nil, then it will behave as it does currently.However, the concrete type should only be supplied to
convertConstif the call expression's type and the constant expression's type both have the same underlying unsigned type -- the base type of any value of these types were they to be evaluated as literals before being assigned a type.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description