Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #1428

Merged
merged 3 commits into from
Jan 7, 2024
Merged

docs: fix typos #1428

merged 3 commits into from
Jan 7, 2024

Conversation

tranhoaison
Copy link
Contributor

Hey, I just fixed some typos.

@tranhoaison tranhoaison requested review from jaekwon, moul and a team as code owners December 9, 2023 04:45
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Dec 9, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1b514c) 56.08% compared to head (1e70b0f) 56.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   56.08%   56.09%   +0.01%     
==========================================
  Files         432      432              
  Lines       65971    65971              
==========================================
+ Hits        37001    37009       +8     
+ Misses      26078    26068      -10     
- Partials     2892     2894       +2     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuricmp iuricmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zivkovicmilos zivkovicmilos changed the title fix some typos fix: some typos Dec 31, 2023
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🙏

Can you please merge in master changes into your branch and resolve conflicts?

@tranhoaison tranhoaison requested a review from a team as a code owner January 1, 2024 09:19
@tranhoaison
Copy link
Contributor Author

Thank you for the contribution 🙏

Can you please merge in master changes into your branch and resolve conflicts?

Hi, it seems fine now.

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for pointing these out! 🥇

@thehowl thehowl changed the title fix: some typos docs: fix typos Jan 7, 2024
@thehowl thehowl merged commit 616a32c into gnolang:master Jan 7, 2024
190 of 191 checks passed
gfanton pushed a commit to moul/gno that referenced this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants