fix(gnoweb): FaucetURL correct endpoint #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1449 +/- ##
==========================================
+ Coverage 55.87% 56.12% +0.25%
==========================================
Files 430 431 +1
Lines 65618 65860 +242
==========================================
+ Hits 36667 36967 +300
+ Misses 26083 26009 -74
- Partials 2868 2884 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7 tasks
zivkovicmilos
approved these changes
Dec 19, 2023
thehowl
reviewed
Dec 19, 2023
| @@ -20,7 +20,7 @@ | |||
| {{ end }} | |||
| </script> | |||
|
|
|||
| <form method="POST" action="{{ .Data.faucetURL }}"> | |||
| <form method="POST" action="{{ .Data.Faucet.faucetURL }}"> | |||
There was a problem hiding this comment.
Side-note: what a horrible templating engine we use. (These kind of errors can normally be caught by html/template if it's using structs under the hood, but here we're using a bunch of map-string-interfaces so no errors are caught...)
Have you tested this works? Reding through the code it shouldn't, this change should:
Suggested change
| <form method="POST" action="{{ .Data.Faucet.faucetURL }}"> | |
| <form method="POST" action="{{ .Data.Config.FaucetURL }}"> |
There was a problem hiding this comment.
OH Damn!
You're half right, i'm using gnolang/faucet, which use different variable name 😮💨
moul
approved these changes
Dec 19, 2023
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> Following PR https://github.com/gnolang/gno/pull/1444/files This is needed for portal loop <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR https://github.com/gnolang/gno/pull/1444/files
This is needed for portal loop
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description