feat(grc20,foo20): lazily resolve username in grc20 (and foo20) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
changed the title
moul-bot
force-pushed
the
dev/moul/grc20-users
branch
from
7465aa0
to
dec1a47
Compare
jaekwon
reviewed
Apr 29, 2022
jaekwon
reviewed
Apr 29, 2022
moul-bot
force-pushed
the
dev/moul/grc20-users
branch
from
dec1a47
to
befffb7
Compare
|
How about this? https://github.com/gnolang/gno/pull/166/files |
|
yep, nice, I'll go with it and we can start using "@" prefix everywhere for usernames 👍 will update the PR soon :) |
moul-bot
force-pushed
the
dev/moul/grc20-users
branch
from
1e312db
to
992fc5a
Compare
jaekwon
reviewed
May 5, 2022
jaekwon
reviewed
May 5, 2022
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
…20 and foo20 Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
moul-bot
force-pushed
the
dev/moul/grc20-users
branch
from
7fc1c55
to
0c57267
Compare
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
|
@jaekwon ready for review |
moul
changed the title
moul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The magic of Gno!
Few lines added, and tada, the whole contract supports using registered usernames for both the contract arguments and the Render() path parts.
Closes #166