refactor(gnolang): handle duplicate method decls using TryDefineMethod #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
- Coverage 55.87% 55.87% -0.01%
==========================================
Files 430 430
Lines 65618 65607 -11
==========================================
- Hits 36667 36655 -12
- Misses 26083 26084 +1
Partials 2868 2868
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jaekwon
approved these changes
Jan 8, 2024
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
gnolang#1459) A (IMHO) better method of handling this. Related discussion: gnolang#859 (comment) Avoids creating a panic/recover in Preprocess by handling the "redeclaration" case directly when it happens. cc/ @jaekwon to confirm whether he agrees it's a good solution. (suggestion: review with whitespace hidden)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A (IMHO) better method of handling this. Related discussion: #859 (comment)
Avoids creating a panic/recover in Preprocess by handling the "redeclaration" case directly when it happens.
cc/ @jaekwon to confirm whether he agrees it's a good solution.
(suggestion: review with whitespace hidden)