feat: add a /status.json handler on website #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
changed the title
moul
commented
Apr 29, 2022
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
moul-bot
force-pushed
the
dev/moul/gnoland-status
branch
from
0adf3ba
to
e7bd3ed
Compare
|
Looks good to me so far. |
moul
changed the title
|
ready for review/merge for this part |
|
I came upon this issue searching for another. As gnovm is a form of a financial application, I think we should be on the caution side and reduce time precision either in the gnoweb router or in the VM functions. Access to really precise timestamps either from the outside or inside a vm itself may open access to side-channel vulnerabilities (like spectre or meltdown, https://en.wikipedia.org/wiki/Spectre_(security_vulnerability) ). It's nowhere easy to execute these attacks, but the more you read about this the less you want to take chances. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first simple version of a https://gno.land/status.json endpoint.
It can improve over time, right now my goal was to have an easy way to check the height.