fix(gnofaucet): fix transactions by querying account number and sequence each time #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1493 +/- ##
==========================================
+ Coverage 55.85% 56.11% +0.26%
==========================================
Files 431 432 +1
Lines 65729 65971 +242
==========================================
+ Hits 36713 37022 +309
+ Misses 26140 26058 -82
- Partials 2876 2891 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
We are now using the new faucet at https://github.com/gnolang/faucet which doesn't have this problem. So this PR to fix the old gnofaucet would be reviewed with low priority (or never). Should I close this PR now? |
zivkovicmilos
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Confirming this is broken in the deprecated faucet implementation (in this repo), it's something we've fixed in the new faucet
Thank you for the fix 🙏
thehowl
changed the title
thehowl
approved these changes
Jan 11, 2024
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
…nce each time (gnolang#1493) Currently, `gnofaucet` [queries the blockchain once](https://github.com/gnolang/gno/blob/c3a4993335f8881989eb49e4efea6a3c1310061d/gno.land/cmd/gnofaucet/serve.go#L191-L209) for the account number and sequence number, and [increments the sequence number](https://github.com/gnolang/gno/blob/master/gno.land/cmd/gnofaucet/serve.go#L327) each time that it sends coins. We are using `gnofaucet` with `gnodev`. When `gnodev` restarts the chain, it also resets the sequence number. This means that we also have to restart `gnofaucet` (to re-query the sequence number), which is inconvenient for the development workflow. If you agree that it would be nice for `gnofaucet` to continue to work after `gnodev` does a reset, then this pull request moves the query for the account number and sequence number into the `sendAmountTo` function so that it queries each time it signs a transaction. Now `gnofaucet` continues to function even if the sequence number is unexpectedly changed (because the blockchain is reset or because some other transaction is signed with the same key). Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
gnofaucetqueries the blockchain once for the account number and sequence number, and increments the sequence number each time that it sends coins. We are usinggnofaucetwithgnodev. Whengnodevrestarts the chain, it also resets the sequence number. This means that we also have to restartgnofaucet(to re-query the sequence number), which is inconvenient for the development workflow.If you agree that it would be nice for
gnofaucetto continue to work aftergnodevdoes a reset, then this pull request moves the query for the account number and sequence number into thesendAmountTofunction so that it queries each time it signs a transaction. Nowgnofaucetcontinues to function even if the sequence number is unexpectedly changed (because the blockchain is reset or because some other transaction is signed with the same key).