fix(r/demo/boards): update the user link in displayAddressMD to correct path #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1525 +/- ##
==========================================
+ Coverage 56.09% 56.10% +0.01%
==========================================
Files 432 432
Lines 66081 66081
==========================================
+ Hits 37069 37078 +9
+ Misses 26114 26107 -7
+ Partials 2898 2896 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…users Signed-off-by: Jeff Thompson <jeff@thefirst.org>
thehowl
changed the title
This was referenced Jan 12, 2024
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
…ct path (gnolang#1525) This updates r/demo/boards to fix the link when clicking in a username. To see the problem, visit https://test3.gno.land/r/demo/boards:testboard . Click on the username `@administrator`. The result is "404 page not found". The problem is that the URL created by `displayAddressMD` is: https://test3.gno.land/r/users:administrator but it should be https://test3.gno.land/r/demo/users:administrator The first commit changes `displayAddressMD` to the correct "r/demo/users". The second commit updates the expected test outputs. --------- Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates r/demo/boards to fix the link when clicking in a username. To see the problem, visit https://test3.gno.land/r/demo/boards:testboard . Click on the username
@administrator. The result is "404 page not found". The problem is that the URL created bydisplayAddressMDis:https://test3.gno.land/r/users:administrator
but it should be
https://test3.gno.land/r/demo/users:administrator
The first commit changes
displayAddressMDto the correct "r/demo/users". The second commit updates the expected test outputs.