Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make gnokeykc use gnokey's basecfg #1531

Merged
merged 2 commits into from
Jan 18, 2024
Merged

chore: make gnokeykc use gnokey's basecfg #1531

merged 2 commits into from
Jan 18, 2024

Conversation

moul
Copy link
Member

@moul moul commented Jan 12, 2024 •
edited by moul-sudo

Related with #1233.

Before

$ gnokeykc --help                                                                                                                                                                                                                                                            
[...]
  -config ...                     config file (optional)                                                                                                                                                                                                                                                 
[...]

After

$ gnokeykc --help                                                                                                                                                                                                                                                                 
[...]
  -home /Users/moul/Library/Application Support/gno  home directory                                                                                                                                                                                                                                      
[...]
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@moul
chore: make gnokeykc use gnokey's basecfg
5145e4d 
Signed-off-by: moul <94029+moul@users.noreply.github.com>
@moul moul self-assigned this Jan 12, 2024
@moul-sudo moul-sudo marked this pull request as ready for review January 12, 2024 19:51
@moul-sudo moul-sudo requested a review from a team as a code owner January 12, 2024 19:51
thehowl
thehowl approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, agree to apply hariom's comment

@thehowl @harry-hov
Update contribs/gnokeykc/main.go
8bdf975 
Co-authored-by: Hariom Verma <hariom18599@gmail.com>
@thehowl thehowl merged commit 37e7258 into gnolang:master Jan 18, 2024
8 checks passed
@thehowl thehowl mentioned this pull request Jan 18, 2024
Merged
@zivkovicmilos zivkovicmilos mentioned this pull request Jan 22, 2024
Open
thehowl added a commit that referenced this pull request Jan 23, 2024
@thehowl
chore: make gnokey consistent with the changes applied to gnokeykc (#…
7888dca 
…1554)

See #1531
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Jan 31, 2024
@thehowl @leohhhn
chore: make gnokey consistent with the changes applied to gnokeykc (g…
ed0676c 
…nolang#1554)

See gnolang#1531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harry-hov harry-hov harry-hov left review comments

@thehowl thehowl thehowl approved these changes

@gfanton gfanton Awaiting requested review from gfanton

Assignees

@moul moul

Labels
None yet
Projects
💪 Bounties & Worx
Status: Done
😎 Manfred's Board
Status: Done
🚀 The Launch
Status: No status
🧐 Review Meeting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moul @thehowl @harry-hov