Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/gno): correctly filter filetests in listNonTestFiles #1560

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

harry-hov
Copy link
Member

s/HasPrefix/HasSuffix

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@harry-hov harry-hov added the 🐞 bug Something isn't working label Jan 18, 2024
@harry-hov harry-hov requested a review from a team as a code owner January 18, 2024 18:07
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jan 18, 2024
@harry-hov harry-hov changed the title fix: listNonTestFiles() correclty filter test files fix: listNonTestFiles() correctly filter test files Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07c6065) 55.73% compared to head (c48175d) 55.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1560   +/-   ##
=======================================
  Coverage   55.73%   55.73%           
=======================================
  Files         435      435           
  Lines       65933    65933           
=======================================
  Hits        36748    36748           
  Misses      26303    26303           
  Partials     2882     2882           
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl changed the title fix: listNonTestFiles() correctly filter test files fix(cmd/gno): correctly filter filetests in listNonTestFiles Jan 18, 2024
@thehowl thehowl merged commit b30444f into gnolang:master Jan 18, 2024
191 of 192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants