feat(examples): add package cford32, add method seqid.ID.String
#1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1572 +/- ##
==========================================
+ Coverage 44.31% 47.41% +3.10%
==========================================
Files 438 385 -53
Lines 66019 61319 -4700
==========================================
- Hits 29255 29074 -181
+ Misses 34341 29826 -4515
+ Partials 2423 2419 -4 ☔ View full report in Codecov by Sentry. |
thehowl
added a commit
that referenced
this pull request
Jan 23, 2024
Pull request #1572 marks the codeowner as @moul, in spite of what the configuration might suggest to a human reader. [Reading through GitHub's docs](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file), this seems to come from the fact that if directories are not prefixed with a `/`, they are considered as applying to all files or directories with that name. (ie. `foo` matches `/foo` but also `/src/foo`). I've added `/` to all directories in CODEOWNERS to fix this.
thehowl
requested review from
a team,
jaekwon,
piux2 and
zivkovicmilos
as code owners
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Jan 31, 2024
Pull request gnolang#1572 marks the codeowner as @moul, in spite of what the configuration might suggest to a human reader. [Reading through GitHub's docs](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file), this seems to come from the fact that if directories are not prefixed with a `/`, they are considered as applying to all files or directories with that name. (ie. `foo` matches `/foo` but also `/src/foo`). I've added `/` to all directories in CODEOWNERS to fix this.
zivkovicmilos
approved these changes
Feb 15, 2024
moul
approved these changes
Feb 22, 2024
3 tasks
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Feb 29, 2024
…olang#1572) This PR adds a new package to examples, `cford32`, meant primarily to be used in package `seqid` as an AVL- and human-friendly ID, which implements an encoding scheme with the base32 encoding scheme [specified by Douglas Crockford](https://www.crockford.com/base32.html). It additionally implements a `uint64` encoding scheme I created, which encodes "tiny" (< 17 billion) values as 7-byte strings, and can encode the full `uint64` range with 13 bytes. The package is largely a fork of Go's `encoding/base32`, intentionally forked to have a very familiar API, while needing to be forked to implement some distinctive features of the encoding (like case insensitivity, and mapping in decoding all of the symbols `l L i I 1` to the same value). The necessity of this package comes from a solution that I implemented in GnoChess: https://github.com/gnolang/gnochess/blob/9aa813fbb86fec377a85fc4528411d652fc780ff/realm/chess.gno#L286-L295 Essentially, GnoChess used simple sequential IDs for its saved entities (like games). To work well with AVL's sorted keys, it padded the generated strings to the left with up to 9 zeroes. This, of course, breaks for values `>= 1e10` (10 billion), as `("2" + "000000000") > ("10" + "000000000")`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new package to examples,
cford32, meant primarily to be used in packageseqidas an AVL- and human-friendly ID, which implements an encoding scheme with the base32 encoding scheme specified by Douglas Crockford. It additionally implements auint64encoding scheme I created, which encodes "tiny" (< 17 billion) values as 7-byte strings, and can encode the fulluint64range with 13 bytes.The package is largely a fork of Go's
encoding/base32, intentionally forked to have a very familiar API, while needing to be forked to implement some distinctive features of the encoding (like case insensitivity, and mapping in decoding all of the symbolsl L i I 1to the same value).The necessity of this package comes from a solution that I implemented in GnoChess:
https://github.com/gnolang/gnochess/blob/9aa813fbb86fec377a85fc4528411d652fc780ff/realm/chess.gno#L286-L295
Essentially, GnoChess used simple sequential IDs for its saved entities (like games). To work well with AVL's sorted keys, it padded the generated strings to the left with up to 9 zeroes. This, of course, breaks for values
>= 1e10(10 billion), as("2" + "000000000") > ("10" + "000000000").