Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(misc/autocounterd): init autocounterd #1612

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

albttx
Copy link
Member

@albttx albttx commented Feb 1, 2024

A demo is currently running on the portal loop

you can check https://portal.gnoteam.com/r/portal/counter

close: #1443

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.79%. Comparing base (69811ff) to head (e8a22ba).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1612      +/-   ##
==========================================
+ Coverage   47.74%   47.79%   +0.05%     
==========================================
  Files         393      393              
  Lines       61629    61731     +102     
==========================================
+ Hits        29424    29505      +81     
- Misses      29734    29750      +16     
- Partials     2471     2476       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albttx albttx force-pushed the misc/autocounterd branch 2 times, most recently from 2fd9f08 to 310f716 Compare February 1, 2024 13:52
misc/autocounterd/README.md Outdated Show resolved Hide resolved
misc/autocounterd/go.mod Show resolved Hide resolved
misc/autocounterd/go.mod Show resolved Hide resolved
misc/autocounterd/README.md Outdated Show resolved Hide resolved
misc/autocounterd/cmd/cmd_start.go Outdated Show resolved Hide resolved
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

misc/autocounterd/cmd/cmd_start.go Show resolved Hide resolved
@harry-hov harry-hov self-requested a review March 6, 2024 13:28
@albttx
Copy link
Member Author

albttx commented Mar 7, 2024

@thehowl Can this be merge ?

@thehowl
Copy link
Member

thehowl commented Mar 7, 2024

@albttx We need a second review 🥲 (I pinged the team on monday)

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

misc/autocounterd/README.md Outdated Show resolved Hide resolved
misc/autocounterd/go.mod Outdated Show resolved Hide resolved
misc/autocounterd/go.mod Outdated Show resolved Hide resolved
misc/autocounterd/cmd/cmd_start.go Show resolved Hide resolved
misc/autocounterd/r/autocounterd/autocounder.gno Outdated Show resolved Hide resolved
@albttx
Copy link
Member Author

albttx commented Apr 8, 2024

@thehowl @zivkovicmilos All good, all fixed,

ps: sorry for --rebase push force 🙈

@zivkovicmilos
Copy link
Member

@albttx
Make sure to run make tidy from the repo root to recursively tidy go mods 🙏

Otherwise we're good to merge

@albttx
Copy link
Member Author

albttx commented Apr 9, 2024

@zivkovicmilos good :)

Co-authored-by: Hariom Verma <hariom18599@gmail.com>
@zivkovicmilos zivkovicmilos merged commit 2a9a8f5 into gnolang:master Apr 10, 2024
180 of 181 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: No status
Status: Done
Development

Successfully merging this pull request may close these issues.

Portal Loop: monitoring agent/oracle
4 participants