Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github): dependabot group for all GH actions #1628

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 2, 2024

Continuing the work in #1553, this adds a dependabot group to update all GH actions together.

@thehowl thehowl self-assigned this Feb 2, 2024
@thehowl thehowl requested review from moul and a team as code owners February 2, 2024 16:10
@kristovatlas
Copy link
Contributor

Some limitations to note for reviewers: source

  • Dependabot only supports updates to GitHub Actions using the GitHub repository syntax, such as actions/checkout@v4. Dependabot will ignore actions or reusable workflows referenced locally (for example, ./.github/actions/foo.yml).
  • Docker Hub and GitHub Packages Container registry URLs are currently not supported. For example, references to Docker container actions using docker:// syntax aren't supported.

@kristovatlas
Copy link
Contributor

If a change to dependabot.yaml breaks something, how will we observe this?

Copy link
Contributor

@kristovatlas kristovatlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested but LGTM

Copy link

@MichaelFrazzy MichaelFrazzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems really useful! Do you see this including the user profile Actions/workflows as well? Essentially us trying to get all related tests/workflows running from the same .yml file and CI build?

As is I have a different .yml file for each action and script to be super sure during testing, but I can look into combining them all under this. All 3 use checkout@v2 so far through a Ubuntu actions/setup-python@v4 setup, sounds like the latter part could be an issue.

@thehowl
Copy link
Member Author

thehowl commented Feb 8, 2024

If a change to dependabot.yaml breaks something, how will we observe this?

I tried looking up on the internet how we could solve this, and laughed out loud reading this SO answer:

image

The action mentioned seems to be fixed. I made a PR to add it: #1642.

@thehowl
Copy link
Member Author

thehowl commented Feb 8, 2024

Do you see this including the user profile Actions/workflows as well?

Kind of unrelated here. This just tells dependabot to be less annoying and batch all PRs to update GH actions into one.

Essentially us trying to get all related tests/workflows running from the same .yml file and CI build?

Nah, that's unnecessary. Specifying different jobs, even if they have to re-do the same thing, is good because it allows the jobs to be easily parallelised by the runners.

@thehowl thehowl merged commit f060eb3 into master Feb 8, 2024
8 checks passed
@thehowl thehowl deleted the dev/morgan/gh-actions-dependabot-group branch February 8, 2024 15:32
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 8, 2024
Continuing the work in gnolang#1553, this adds a dependabot group to update all
GH actions together.
thehowl added a commit that referenced this pull request Feb 22, 2024
following [this
comment](#1628 (comment))
from @kristovatlas

This action seems to only validate the JSON schema. For full validation,
it's on GitHub to provide this -- tracked in this issue:
dependabot/dependabot-core#4605
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
following [this
comment](gnolang#1628 (comment))
from @kristovatlas

This action seems to only validate the JSON schema. For full validation,
it's on GitHub to provide this -- tracked in this issue:
dependabot/dependabot-core#4605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants