Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add edit page link and info #1629

Merged
merged 1 commit into from
Feb 5, 2024
Merged

docs: add edit page link and info #1629

merged 1 commit into from
Feb 5, 2024

Conversation

alexiscolin
Copy link
Member

Related to #1505,This PR aims to add the edit page option in order to link the source md file to docs page. So readers will be invited to edit the page to improve it. It also add the last update date, so readers can know if the page is up to date.

@alexiscolin alexiscolin requested a review from a team as a code owner February 4, 2024 00:19
@alexiscolin alexiscolin self-assigned this Feb 4, 2024
@alexiscolin alexiscolin added the 📖 documentation Improvements or additions to documentation label Feb 4, 2024
Copy link

@MichaelFrazzy MichaelFrazzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work, both the idea for the form itself and adding the ability to edit the docs! Will it "optimistically" accept edits without a check of some kind? Just thinking safeguards against potential trolls if edit is open to everyone.

Also I'm a bit more familiar with CSS than I am Go (but only vaguely more familiar with JS haha), and I can't find any other bugs. As long as the --ifm-font-color-base variables being repeated for the different themes is a purposeful redefinition (which it seems like it is). And -webkit-scrollbar has given me some issues with non-chromium based browsers in the past but I've heard that's largely been fixed too. Thanks for this!

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexiscolin!

@MichaelFrazzy, no worries, all changes need to go through a PR anyways, so as long as we do our job we should be fine :)

@leohhhn leohhhn merged commit 05dccce into gnolang:master Feb 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants