Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): fix tests #1669

Merged
merged 1 commit into from
Feb 19, 2024
Merged

chore(examples): fix tests #1669

merged 1 commit into from
Feb 19, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 19, 2024

muscle memory ignored the failing CI due to bft once again...

@thehowl thehowl self-assigned this Feb 19, 2024
@thehowl thehowl requested a review from moul as a code owner February 19, 2024 19:13
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b474043) 53.34% compared to head (a4777d6) 56.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1669      +/-   ##
==========================================
+ Coverage   53.34%   56.11%   +2.77%     
==========================================
  Files         480      447      -33     
  Lines       72597    66712    -5885     
==========================================
- Hits        38725    37435    -1290     
+ Misses      30865    26362    -4503     
+ Partials     3007     2915      -92     
Flag Coverage Δ
go-1.22.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@thehowl thehowl merged commit 1c6d184 into master Feb 19, 2024
187 of 188 checks passed
@thehowl thehowl deleted the dev/morgan/fix-ci-examples branch February 19, 2024 21:02
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
muscle memory ignored the failing CI due to bft once again...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants