chore(tm2/pkg/std): add failing regexp in MemPackage.Validate's errors #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this helps a cli user to know what went wrong directly (otherwise, he has to look at gno/tm2/pkg/std/memfile.go).
grepsuzette
requested review from
jaekwon,
piux2,
moul and
zivkovicmilos
as code owners
thehowl
approved these changes
Feb 21, 2024
thehowl
changed the title
|
Thanks! |
zivkovicmilos
approved these changes
Feb 21, 2024
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Feb 29, 2024
gnolang#1673) This helps a cli user to know what went wrong directly (otherwise, he has to look at gno/tm2/pkg/std/memfile.go). Since the cli user is a technical one, it makes no sense to not show this. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> Co-authored-by: grepsuzette <grepsuzette@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps a cli user to know what went wrong directly (otherwise, he has to look at gno/tm2/pkg/std/memfile.go).
Since the cli user is a technical one, it makes no sense to not show this.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description