Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(labeler): fix labeler configuration #1679

Merged
merged 3 commits into from
Feb 22, 2024
Merged

ci(labeler): fix labeler configuration #1679

merged 3 commits into from
Feb 22, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 22, 2024

Update the labeler configuration with the move to its v5.

The labeler CI will keep on failing because it runs for pull_request_target, which runs in the context of the base branch rather than the PR's branch. Practically, it means that the only way to make sure it works is by merging it :P

@thehowl thehowl requested review from moul and a team as code owners February 22, 2024 11:27
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means that the only way to make sure it works is by merging it :)

Let's find out!

@thehowl thehowl merged commit 989e6d6 into master Feb 22, 2024
64 of 68 checks passed
@thehowl thehowl deleted the dev/morgan/fix-ci branch February 22, 2024 16:56
leohhhn pushed a commit to leohhhn/gno that referenced this pull request Feb 29, 2024
Update the labeler configuration with the move to its v5.

The labeler CI will keep on failing because it runs for
`pull_request_target`, which runs in the context of the base branch
rather than the PR's branch. Practically, it means that the only way to
make sure it works is by merging it :P
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants