feat(precompile): use //line directive in generated go files
#1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR gnolang#1670 updated the `gno precompile` output by translating errors reported by generated go files into their corresponding gno files. This was done by shifting the line number, since generated go files have an extra header of 4 lines. @thehowl found a better way to do this by using the //line directive. By adding this directive at the end of this extra header we have in generated go files, the go compiler will skip it and output a file position that exactly matches the gno file position. This eliminates the need for the line shifting mentioned above. See https://pkg.go.dev/cmd/compile#hdr-Compiler_Directives
tbruyelle
requested review from
jaekwon,
piux2,
thehowl,
moul and
harry-hov
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1688 +/- ##
=======================================
Coverage 47.48% 47.48%
=======================================
Files 385 385
Lines 61408 61406 -2
=======================================
Hits 29159 29159
+ Misses 29812 29810 -2
Partials 2437 2437 ☔ View full report in Codecov by Sentry. |
thehowl
reviewed
Feb 28, 2024
So we don't even have to remove the .gen.go extension when we parse the go build errors.
thehowl
approved these changes
Feb 28, 2024
thehowl
changed the title
//line directive in generated go files
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Feb 29, 2024
…ng#1688) PR gnolang#1670 updated the `gno precompile` output by translating errors reported by generated go files into their corresponding gno files. This was done by shifting the line number, since generated go files have an extra header of 4 lines. @thehowl found a better way to do this by using the //line directive. By adding this directive at the end of this extra header we have in generated go files, the go compiler will skip it and output a file position that exactly matches the gno file position. This eliminates the need for the line shifting mentioned above. See https://pkg.go.dev/cmd/compile#hdr-Compiler_Directives <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1670 updated the
gno precompileoutput by translating errors reported by generated go files into their corresponding gno files. This was done by shifting the line number, since generated go files have an extra header of 4 lines.@thehowl found a better way to do this by using the //line directive. By adding this directive at the end of this extra header we have in generated go files, the go compiler will skip it and output a file position that exactly matches the gno file position. This eliminates the need for the line shifting mentioned above.
See https://pkg.go.dev/cmd/compile#hdr-Compiler_Directives
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description