chore: decapitalize short help and flag usage #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry-hov
requested review from
moul,
gfanton,
jaekwon,
thehowl,
a team,
piux2 and
zivkovicmilos
as code owners
github-actions
bot
added
📦 🤖 gnovm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1701 +/- ##
==========================================
+ Coverage 47.41% 47.43% +0.01%
==========================================
Files 384 384
Lines 61240 61205 -35
==========================================
- Hits 29040 29032 -8
+ Misses 29771 29744 -27
Partials 2429 2429 ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Feb 28, 2024
7 tasks
gfanton
approved these changes
Feb 29, 2024
|
There's a failing test, good to merge after fixing that |
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Mar 6, 2024
…ng#1701) In some places, the first letter of the short help or flag usage is lowercase, and in some places, it's uppercase. Right now, it is very random, let's have something uniform across the codebase. Went with lowercase as Go cmd uses the same. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places, the first letter of the short help or flag usage is lowercase, and in some places, it's uppercase. Right now, it is very random, let's have something uniform across the codebase.
Went with lowercase as Go cmd uses the same.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description