Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vm): fix a crash when requesting a missing file #172

Merged
merged 2 commits into from
May 9, 2022

Conversation

jubnzv
Copy link
Contributor

@jubnzv jubnzv commented May 7, 2022

We could test it using the web-interface. Open a file: https://gno.land/r/boards/missing.txt (or http://127.0.0.1:8888/r/boards/missing.txt on a local node).

Before:

RPC error -32603 - Internal error: runtime error: invalid memory address or nil pointer dereference

After:

file gno.land/r/boards/missing.txt is not available

Closes #171

@jubnzv jubnzv changed the title vm: Fix a crash when requested a missing file vm: Fix a crash when requesting a missing file May 7, 2022
pkgs/sdk/vm/keeper.go Outdated Show resolved Hide resolved
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul changed the title vm: Fix a crash when requesting a missing file chore(vm): fix a crash when requesting a missing file May 9, 2022
@moul moul merged commit 0df05b7 into gnolang:master May 9, 2022
@moul moul added this to the 🏗2️⃣ test2.gno.land milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Crash when requesting for a missing file
2 participants