refactor(tm2): remove pkg/maths in favour of min/max #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
requested review from
jaekwon,
piux2,
moul and
zivkovicmilos
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1746 +/- ##
==========================================
- Coverage 47.41% 44.70% -2.72%
==========================================
Files 384 455 +71
Lines 61187 67492 +6305
==========================================
+ Hits 29014 30169 +1155
- Misses 29744 34797 +5053
- Partials 2429 2526 +97 ☔ View full report in Codecov by Sentry. |
gfanton
approved these changes
Mar 11, 2024
albttx
pushed a commit
to albttx/gno
that referenced
this pull request
Mar 15, 2024
I was taking a look at what packages we have in tm2/pkg and realised we had an entire package to do what are, since go 1.21, builtin functions. This PR removes tm2/pkg/maths in favour of the now standard and generic go implementation of the same functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was taking a look at what packages we have in tm2/pkg and realised we had an entire package to do what are, since go 1.21, builtin functions.
This PR removes tm2/pkg/maths in favour of the now standard and generic go implementation of the same functionality.