Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnoweb/docs): better website connectivity #1763

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Mar 12, 2024

Description

This PR replaces the "Start" button with the "Docs" button on the gno.land home page navbar, and adds a "Home" button to the docs navbar to interlink the websites in a nice manner. It also fixes a small typo in the GoR page.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Mar 12, 2024
@leohhhn leohhhn added the 📖 documentation Improvements or additions to documentation label Mar 12, 2024
@leohhhn leohhhn marked this pull request as ready for review March 12, 2024 20:27
@leohhhn leohhhn requested review from a team and moul as code owners March 12, 2024 20:27
@leohhhn
Copy link
Contributor Author

leohhhn commented Mar 12, 2024

Looking for opinions - is "Docs" too informal? Should it be "Documentation"?
Screenshot 2024-03-12 at 21 43 04

Screenshot 2024-03-12 at 21 43 54

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.52%. Comparing base (bc77c2b) to head (51376da).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1763   +/-   ##
=======================================
  Coverage   47.52%   47.52%           
=======================================
  Files         388      388           
  Lines       61400    61400           
=======================================
  Hits        29183    29183           
  Misses      29775    29775           
  Partials     2442     2442           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn leohhhn merged commit 82a36f9 into gnolang:master Mar 13, 2024
187 of 188 checks passed
@leohhhn leohhhn deleted the chore/update-navbar-docs branch March 13, 2024 11:56
albttx pushed a commit to albttx/gno that referenced this pull request Mar 15, 2024
## Description

This PR replaces the "Start" button with the "Docs" button on the
gno.land home page navbar, and adds a "Home" button to the docs navbar
to interlink the websites in a nice manner. It also fixes a small typo
in the GoR page.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation 📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants