chore(p/math_eval, gnovm): Simplifying Previous Error Formatting with Errorf
#1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notJoon
requested review from
jaekwon,
piux2,
thehowl,
moul and
a team
as code owners
github-actions
bot
added
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1772 +/- ##
==========================================
+ Coverage 44.81% 47.51% +2.69%
==========================================
Files 459 388 -71
Lines 67707 61373 -6334
==========================================
- Hits 30342 29159 -1183
+ Misses 34827 29772 -5055
+ Partials 2538 2442 -96 ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Mar 14, 2024
leohhhn
approved these changes
Mar 14, 2024
albttx
pushed a commit
to albttx/gno
that referenced
this pull request
Mar 15, 2024
…rorf` (gnolang#1772) ## Description Replace previouse formatted error creations with `fmt.Errof` (in gno, `ufmt.Errorf`) to simplify error creation and formatting. Follow up for PR gnolang#1767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace previouse formatted error creations with
fmt.Errof(in gno,ufmt.Errorf) to simplify error creation and formatting.Follow up for PR #1767