Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add adena wallet in-app faucet account #1808

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

adr-sk
Copy link
Contributor

@adr-sk adr-sk commented Mar 21, 2024

Adena Wallet will add an In-App Faucet in the following version, which requires a dedicated faucet account.

The Faucet will support 2 of the official Gno.land Testnets.

Details of the feature including our policies, the user flow, and a UI preview can be found here: [New Feature] In-app Faucet #454

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@adr-sk adr-sk requested a review from moul as a code owner March 21, 2024 04:19
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.49%. Comparing base (7596f42) to head (771ef63).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1808      +/-   ##
==========================================
+ Coverage   44.79%   47.49%   +2.69%     
==========================================
  Files         459      388      -71     
  Lines       67642    61310    -6332     
==========================================
- Hits        30300    29117    -1183     
+ Misses      34808    29755    -5053     
+ Partials     2534     2438      -96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos
Copy link
Member

@adr-sk

I've created an issue on this topic, and we'll migrate the address from this balances file into a portal loop balance sheet in the future:
#1857

@zivkovicmilos zivkovicmilos merged commit 9e22794 into gnolang:master Mar 29, 2024
181 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants