Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnoland/testdata): mv pr-1112.txtar map-storage.txtar #1810

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Mar 21, 2024

Let's prefer using descriptive filenames, and reference issues only for txtar tests which test against specific regressions.

@thehowl thehowl requested a review from moul as a code owner March 21, 2024 15:26
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Mar 21, 2024
@thehowl thehowl changed the title chore(gnoland/testdata): mv pr-1799.txtar map-storage.txtar chore(gnoland/testdata): mv pr-1112.txtar map-storage.txtar Mar 21, 2024
@thehowl thehowl mentioned this pull request Mar 21, 2024
7 tasks
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.49%. Comparing base (41ff374) to head (f1d4f15).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
+ Coverage   44.80%   47.49%   +2.69%     
==========================================
  Files         459      388      -71     
  Lines       67651    61305    -6346     
==========================================
- Hits        30310    29117    -1193     
+ Misses      34801    29750    -5051     
+ Partials     2540     2438     -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@gfanton gfanton merged commit 497251d into master Mar 21, 2024
181 of 183 checks passed
@gfanton gfanton deleted the dev/morgan/update-pr-1799.txtar-name branch March 21, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants