Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issue warning when gno test package can't be resolved #1845

Merged

Conversation

deelawn
Copy link
Contributor

@deelawn deelawn commented Mar 26, 2024

Pretty straightforward one line change. If gno test fails to find a gno.mod field or package path in gno root, the result will be a panic with the message panic: unexpected unreal object, which makes it pretty difficult to figure out what must be done to correct the issue. The warning gives a solution on how to fix this.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.51%. Comparing base (281815a) to head (0c74401).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1845   +/-   ##
=======================================
  Coverage   47.51%   47.51%           
=======================================
  Files         388      388           
  Lines       61331    61331           
=======================================
  Hits        29144    29144           
  Misses      29747    29747           
  Partials     2440     2440           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deelawn deelawn changed the title improvement: return a clearer error message when gno test package can't be resolved feat: issue warning when gno test package can't be resolved Mar 26, 2024
@deelawn deelawn marked this pull request as ready for review March 26, 2024 22:00
@deelawn deelawn merged commit 0c121a6 into gnolang:master Mar 27, 2024
189 of 192 checks passed
@deelawn deelawn deleted the improvement/gnotest-unresolved-pkgpath branch March 27, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants