feat: meaningful realm finalization panic messages #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1846 +/- ##
==========================================
- Coverage 47.51% 44.85% -2.67%
==========================================
Files 388 459 +71
Lines 61331 67625 +6294
==========================================
+ Hits 29144 30334 +1190
- Misses 29747 34748 +5001
- Partials 2440 2543 +103 ☔ View full report in Codecov by Sentry. |
|
👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only modifies panic messages that occur during realm finalization. It's currently harder than necessary to debug panics from realm finalization when there are 52 places they can happen, granted there are far less when the debug flag is off. Please check for typos and contextual correctness.