Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add testnets concepts & reference pages #1867

Merged
merged 18 commits into from
Apr 8, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Apr 1, 2024

Description

Closes: #1791 & #1822

This PR adds concept & reference pages for Gno testnets. It details out what each testnet is meant for, what its versioning strategy is, and how it handles state & tx history persistence.

I am missing some information -

  • Since test4 will be versioned based on Gno releases, will this also include new code in the examples/ folder? How will this work? cc @zivkovicmilos
  • Please comment below if you know the release dates of test1, test2, & test3 - and possibly the version (gh commit) of their binaries. found tags thanks to @r3v4s on the repo.
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn requested review from a team as code owners April 1, 2024 02:38
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.74%. Comparing base (831bb6f) to head (d8f64f3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1867   +/-   ##
=======================================
  Coverage   47.74%   47.74%           
=======================================
  Files         393      393           
  Lines       61629    61629           
=======================================
  Hits        29424    29424           
  Misses      29734    29734           
  Partials     2471     2471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overal looks good 💯

Left some comments that should be addressed before merging

docs/concepts/testnets.md Outdated Show resolved Hide resolved
docs/concepts/testnets.md Outdated Show resolved Hide resolved
docs/concepts/testnets.md Outdated Show resolved Hide resolved
docs/concepts/testnets.md Outdated Show resolved Hide resolved
docs/concepts/testnets.md Outdated Show resolved Hide resolved
docs/concepts/testnets.md Show resolved Hide resolved
docs/concepts/testnets.md Outdated Show resolved Hide resolved
docs/reference/network-config.md Outdated Show resolved Hide resolved
docs/reference/network-config.md Outdated Show resolved Hide resolved
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for resolving the comments, please check what's leftover 🙏

@leohhhn leohhhn merged commit 1321476 into gnolang:master Apr 8, 2024
26 checks passed
@leohhhn leohhhn deleted the docs/testnets branch April 8, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Document various testnets and their goals
2 participants