feat(p/json): Update JSON package with new validators and functions #1869
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
- Coverage 47.54% 44.84% -2.70%
==========================================
Files 388 459 +71
Lines 61242 67588 +6346
==========================================
+ Hits 29117 30311 +1194
- Misses 29686 34736 +5050
- Partials 2439 2541 +102 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hey @notJoon! Thanks for improving the package. I left some comments that might not need to be addressed in this PR. Take a look at them if you can and leave your thoughts.
I will play around with the package a bit to test out the performance.
| @@ -96,29 +101,33 @@ Encoding (or Marshaling) is the functionality that converts JSON data represente | |||
|
|
|||
| > ⚠️ Caution: Converting a large `Node` type into a JSON string may _impact performance_. or might be cause _unexpected behavior_. | |||
There was a problem hiding this comment.
Typo: or might be cause _unexpected behavior_.
| @@ -71,23 +71,28 @@ Decoding (or Unmarshaling) is the functionality that converts an input byte slic | |||
|
|
|||
| The converted `Node` type allows you to modify the JSON data or search and extract data that meets specific conditions. | |||
|
|
|||
| Below is an example of converting a `Node` type into a JSON string, and retrieving all the keys in the JSON data with `json.UniqueKeyLists()`. | |||
There was a problem hiding this comment.
I suggest you break lines in .md files at 80 chars for easier readability in raw mode ;)
| @@ -71,23 +71,28 @@ Decoding (or Unmarshaling) is the functionality that converts an input byte slic | |||
|
|
|||
| The converted `Node` type allows you to modify the JSON data or search and extract data that meets specific conditions. | |||
|
|
|||
| Below is an example of converting a `Node` type into a JSON string, and retrieving all the keys in the JSON data with `json.UniqueKeyLists()`. | |||
There was a problem hiding this comment.
I think it's a little bit confusing that you're calling a whole JSON string a Node, and then you have each subfield as a Node as well. Was there a specific reason to not call the fields inside the JSON string Fields? Like, FieldString or StringField? WDYT?
| @@ -71,23 +71,28 @@ Decoding (or Unmarshaling) is the functionality that converts an input byte slic | |||
|
|
|||
| The converted `Node` type allows you to modify the JSON data or search and extract data that meets specific conditions. | |||
|
|
|||
| Below is an example of converting a `Node` type into a JSON string, and retrieving all the keys in the JSON data with `json.UniqueKeyLists()`. | |||
There was a problem hiding this comment.
Do we have any metrics on the package? What about adding a few classic test cases to see the performance (with gno test . -print-runtime-metrics)? I think this would also turn into a great piece of code for VM stress-testing later down the line.
Description
This pull request updates the JSON package with new validators and functions. It includes the following changes:
New Feature
FIX