Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use original goleveldb package #1870

Merged

Conversation

zivkovicmilos
Copy link
Member

Description

This PR returns the original import declaration for https://github.com/syndtr/goleveldb.
After internal discussions, we've come to the conclusion that our fork repo is no longer required (since leveldb is no longer a dependency of the gno command)

cc @ilgooz @ajnavarro

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos self-assigned this Apr 1, 2024
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.84%. Comparing base (6760265) to head (2735824).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1870      +/-   ##
==========================================
- Coverage   47.54%   44.84%   -2.70%     
==========================================
  Files         388      459      +71     
  Lines       61242    67588    +6346     
==========================================
+ Hits        29117    30310    +1193     
- Misses      29686    34738    +5052     
- Partials     2439     2540     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos zivkovicmilos merged commit d54ca62 into gnolang:master Apr 1, 2024
194 checks passed
@zivkovicmilos zivkovicmilos deleted the fix/use-original-leveldb branch April 1, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants