fix: labels error handling #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1877 +/- ##
==========================================
- Coverage 47.54% 45.06% -2.48%
==========================================
Files 388 464 +76
Lines 61242 68027 +6785
==========================================
+ Hits 29117 30658 +1541
- Misses 29686 34800 +5114
- Partials 2439 2569 +130 ☔ View full report in Codecov by Sentry. |
petar-dambovaliev
requested review from
jaekwon,
piux2,
thehowl and
moul
as code owners
petar-dambovaliev
requested review from
zivkovicmilos
and removed request for
thehowl
zivkovicmilos
approved these changes
Apr 4, 2024
thehowl
reviewed
Apr 17, 2024
Comment on lines
+26
to
+39
| code: ` | ||
| package test | ||
| func main(){} | ||
| func invalidLabel() { | ||
| FirstLoop: | ||
| for i := 0; i < 10; i++ { | ||
| } | ||
| for i := 0; i < 10; i++ { | ||
| break FirstLoop | ||
| } | ||
| } | ||
| `, | ||
| output: `cannot find branch label "FirstLoop"`, | ||
| }, |
There was a problem hiding this comment.
For next time, please place tests like these in gnovm/tests/files. Goes for all tests which simply run some code and try to test the output or any panic, like these ones
If you're testing specific functions or doing unit tests, then they should go in gnolang, but if they are tests which just run some code against the GnoVM then they should go there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes this
Added error handling on
TRANS_LEAVEduring preprocessing, for break and continue statements that have labels.