Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnoclient): add support for MsgAddPackage #1892

Merged
merged 9 commits into from
Apr 9, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Apr 5, 2024

Description

This PR adds gnoclient support for MsgAddPackage, and updates the docs to match the functionality. Docs preview: https://www.loom.com/share/0dfa38e6e95e4e1195d686c8cbffa453?sid=4af29ee0-d065-442c-977e-ce9577796688

Closes #1840

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 47.76%. Comparing base (831bb6f) to head (7fe592d).
Report is 3 commits behind head on master.

Files Patch % Lines
gno.land/pkg/gnoclient/client_txs.go 80.64% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
+ Coverage   47.74%   47.76%   +0.02%     
==========================================
  Files         393      393              
  Lines       61629    61664      +35     
==========================================
+ Hits        29424    29456      +32     
+ Misses      29734    29731       -3     
- Partials     2471     2477       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn leohhhn marked this pull request as ready for review April 5, 2024 06:55
@leohhhn leohhhn requested review from moul and a team as code owners April 5, 2024 06:55
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

gno.land/pkg/gnoclient/util.go Show resolved Hide resolved
@zivkovicmilos
Copy link
Member

Pinging @gfanton to sign off and we can merge 🚀

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would add a usage example on how you can read and add a std.MemPackage. It can be tricky for a new user to figure out how to do that.

docs/reference/gnoclient/client.md Show resolved Hide resolved
@leohhhn leohhhn merged commit 60c09b9 into gnolang:master Apr 9, 2024
183 of 184 checks passed
@leohhhn leohhhn deleted the gnoclient/addpkg branch April 9, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: No status
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[gnoclient] Add support for MsgAddPackage
3 participants